Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rework tests in order to make the dedicated module work without replacements #148

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

omissis
Copy link
Owner

@omissis omissis commented Oct 4, 2023

fixes #131

@omissis omissis self-assigned this Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b0ec161) 61.84% compared to head (1c0b634) 55.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
- Coverage   61.84%   55.56%   -6.28%     
==========================================
  Files          23       15       -8     
  Lines        2034     1634     -400     
==========================================
- Hits         1258      908     -350     
+ Misses        692      619      -73     
- Partials       84      107      +23     
Files Coverage Δ
tests/data/extraImports/gopkgYAMLv3/gopkgYAMLv3.go 20.00% <ø> (ø)
tests/data/validation/maxLength/maxLength.go 71.42% <100.00%> (ø)
tests/data/validation/minLength/minLength.go 71.42% <100.00%> (ø)
tests/helpers/checks.go 16.66% <ø> (ø)

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omissis omissis merged commit 14c6755 into main Oct 4, 2023
@omissis omissis deleted the fix/tests-module branch October 4, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go install complains on go.mod
1 participant