Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle EngineAPI application errors #2461

Closed
corverroos opened this issue Nov 12, 2024 · 0 comments
Closed

Handle EngineAPI application errors #2461

corverroos opened this issue Nov 12, 2024 · 0 comments
Labels
cantina
Milestone
1.1 - Mainnet Bet...

Comments

@corverroos
Copy link
Collaborator

Problem to Solve

EngineAPI spec doesn't specify that status==Invalid MUST not also return an error. Geth actually returns both. Our retryForever logic doesn't distinghusih between the two.

Proposed Solution

Check for status==Invalid BEFORE retrying all other errors.
@corverroos corverroos mentioned this issue Nov 13, 2024
Merged
corverroos added a commit that referenced this issue Nov 13, 2024
@corverroos
fix(octane/evmengine): handle engine errors (#2469)
c5dc5fc 
Improve EngineAPI error handling:
- Geth returns `status:INVALID` AND errors, so swallow errors if known
status is returned.
- Remaining errors (with unknown status) should only be temporary
networking (or some unexpected geth error).
- Timeout PrepareProposal after 10s, proposing an empty consensus block
rather (other validators probably already moved on in any case.)
 - Timeout ProcessProposal after 1min, prevent blocking forever

issue: #2461
@corverroos corverroos added this to the 1.1 - Mainnet Beta [Dec 4] milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cantina
Projects
None yet
Milestone
1.1 - Mainnet Beta [Dec 4]
Development

No branches or pull requests
1 participant
@corverroos