Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve request context in SolveInbox #2679

Open
Zodomo opened this issue Dec 11, 2024 · 0 comments
Open

Improve request context in SolveInbox #2679

Zodomo opened this issue Dec 11, 2024 · 0 comments
Assignees
@Zodomo

Comments

@Zodomo
Copy link
Contributor

Zodomo commented Dec 11, 2024

Problem to Solve

In order to determine north star metrics like solve latency, we need historical timestamps as a request goes through status updates. We also need to see which request was most recently switched to any given status.

Proposed Solution

Add update history to the requests and include a mapping binding each status value to the most recent request to apply it.
@Zodomo Zodomo self-assigned this Dec 11, 2024
@Zodomo Zodomo mentioned this issue Dec 11, 2024
Merged
Zodomo added a commit that referenced this issue Dec 11, 2024
@Zodomo
feat(contracts/solve): most recent request per status (#2675)
30c9c93 
Added `getLatestRequestByStatus(status)`, which retrieves the most
recent request to be set to a particular status. I also replaced the
`deployedAt` Arbitrum branch handling with something much more robust.

I attempted to add `getRequestUpdateHistory(id)`, which would return the
timestamp history for all status updates a request has undergone.
Despite this not altering the request and fulfillment flows, it broke
the e2e tests, so this has been excluded for now.

issue: #2679
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zodomo Zodomo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Zodomo