feat(realyer): cache height for offset search #2325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sideninja
commented
Oct 29, 2024
sideninja
commented
Oct 29, 2024
sideninja
commented
Oct 29, 2024
sideninja
requested review from
corverroos,
chmllr,
kc1116 and
kevinhalliday
as code owners
corverroos
reviewed
Oct 30, 2024
kc1116
approved these changes
Oct 30, 2024
corverroos
requested changes
Oct 31, 2024
corverroos
reviewed
Oct 31, 2024
corverroos
reviewed
Oct 31, 2024
corverroos
reviewed
Nov 4, 2024
corverroos
reviewed
Nov 4, 2024
corverroos
reviewed
Nov 4, 2024
corverroos
reviewed
Nov 4, 2024
corverroos
approved these changes
Nov 4, 2024
sideninja
force-pushed
the
gregor/cache-offset
branch
from
627f518 to
5a31104
Compare
sideninja
force-pushed
the
gregor/cache-offset
branch
from
5a31104 to
19c6b34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache the height found during attestation offset lookback search so it can be reused on the next offset search.
issue: #1860