fix(relayer): fix tx spend calc for op chains #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinhalliday
requested review from
corverroos,
sideninja,
chmllr and
kc1116
as code owners
kevinhalliday
commented
Nov 1, 2024
kevinhalliday
commented
Nov 1, 2024
corverroos
reviewed
Nov 3, 2024
corverroos
reviewed
Nov 3, 2024
corverroos
reviewed
Nov 3, 2024
corverroos
reviewed
Nov 4, 2024
| @@ -166,23 +181,21 @@ func getFees( | |||
| fees.nETH += feesGwei | |||
| fees.nUSD += feesGwei * prices[tokens.ETH] | |||
There was a problem hiding this comment.
best error if prices don't contain expect token
There was a problem hiding this comment.
coingecko provider makes those checks
corverroos
approved these changes
Nov 5, 2024
kevinhalliday
force-pushed
the
kh/opreceipts
branch
from
83670bb to
308159b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PnL metrics / logs for op chains.
OP receipts include L1GasUsed, L1GasPrice, and L1Fee (L1GasPrice * L1GasUsed).
We need to include these in spend calc.
issue: #2354