feat(contracts/core): add additional actions to inbox #2360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Can we change pr title (which will be commit message) to a feat(contracts/core): ...
We are adding to Inbox, not just adding tests
- Let's make all methods
nonReentrant. But definitely cancel. Otherwise we could have some malicious cancellations while opening a request. - Thinking we actually do keep requests around for now, and just change status (see my comment below). Think the view function will be helpful. We can switch later if we don't need it
Also, can you move the function tests cases to their own files.
Inbox_accept.t.sol
Inbox_reject.t.sol
Inbox_cancel.t.sol
Hlps keeps tests files a bit smaller
Sol artifacts changed because adding solady import changed metadata
corverroos
changed the title
Zodomo
changed the title
Zodomo
requested review from
corverroos,
sideninja,
chmllr and
kc1116
as code owners
kevinhalliday
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced OpenZeppelin libs with gas-optimized Solady alternatives. Expanded solve Inbox to include accept, reject, and cancel logic. Also implemented tests for these flows.
issue: #2355