Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e/app): disable testUpgradeBridgeNative #2389

Merged
merged 1 commit into from
Nov 5, 2024
Merged

test(e2e/app): disable testUpgradeBridgeNative #2389

merged 1 commit into from
Nov 5, 2024

Conversation

Zodomo
Copy link
Contributor

@Zodomo Zodomo commented Nov 5, 2024 •
edited
Loading

Disable the test for OmniBridgeNative as it was failing because the bridge has not yet been upgraded. Post-upgrade the test can be reenabled.

issue: none

@Zodomo Zodomo self-assigned this Nov 5, 2024
kevinhalliday
kevinhalliday approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@kevinhalliday kevinhalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try running admin tests locally. You can check gh workflow for command (right now they are only run on merge to main).

@Zodomo
Copy link
Contributor Author

Zodomo commented Nov 5, 2024

Ran the go run github.com/omni-network/omni/e2e admin test -f e2e/manifests/devnet1.toml command from the e2e-test-admin workflow and it was successful.

@Zodomo Zodomo merged commit 475cb63 into main Nov 5, 2024
19 checks passed
@Zodomo Zodomo deleted the zodomo/disable-upgrade-bridge branch November 5, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinhalliday kevinhalliday kevinhalliday approved these changes

@corverroos corverroos Awaiting requested review from corverroos corverroos is a code owner

@sideninja sideninja Awaiting requested review from sideninja

@chmllr chmllr Awaiting requested review from chmllr chmllr is a code owner

@kc1116 kc1116 Awaiting requested review from kc1116 kc1116 is a code owner

Assignees

@Zodomo Zodomo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zodomo @kevinhalliday