fix(octane/evmengine): graceful post finalize errors #2508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmllr
approved these changes
Nov 19, 2024
0xHansLee
added a commit
to piplabs/story
that referenced
this pull request
Nov 25, 2024
This PR is the commit from Omni to handle errors in PostFinalize gracefully (omni-network/omni#2508). When non-deterministic response received from CometBFT, skip optimistic build. issue: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't error (stall node) in
PostFinalizeifCometBFT.Validatorsreturns an error, rather handle it graacefully and skip optimisic build.CometBFT.Validatorsis non-deterministic and may return unexpected errors in edge cases.issue: #2480