feat(halo/evmstaking2) unit tests for unhappy paths #2591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kc1116
reviewed
Nov 29, 2024
| @@ -88,18 +88,112 @@ func TestInsertAndDeleteEVMEvents(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestHappyPathDelivery(t *testing.T) { | |||
| func TestDeliveryWithBrokenServer(t *testing.T) { | |||
chmllr
changed the title
kc1116
reviewed
Nov 29, 2024
|
|
||
| for _, event := range events { | ||
| err := keeper.parseAndDeliver(ctx, &event) | ||
| require.True(t, strings.Contains(err.Error(), sServer.err.Error())) |
There was a problem hiding this comment.
nit: Incorrect syntax usage of require , update all usages.
Suggested change
| require.True(t, strings.Contains(err.Error(), sServer.err.Error())) | |
| require.Error(t, err) | |
| require.Contains(t, err.Error(),"create validator: pubkey to cosmos") |
Using require.Error and require.Contains is preferred as it provides clearer intent, better failure messages, and avoids potential panics if err is nil. It also aligns with idiomatic testing practices for improved readability and debugging.
kc1116
reviewed
Nov 29, 2024
| func (m *stakingKeeperStub) GetValidator(context.Context, sdk.ValAddress) (stypes.Validator, error) { | ||
| m.calls++ | ||
| if m.calls == 1 { | ||
| // GetValidator memorizes all addresses and returns an error for calls it never seen before. |
There was a problem hiding this comment.
Suggested change
| // GetValidator memorizes all addresses and returns an error for calls it never seen before. | |
| // GetValidator tracks accessed addresses, returning an error for unseen addresses. |
kc1116
reviewed
Nov 29, 2024
| m.calls++ | ||
| if m.calls == 1 { | ||
| // GetValidator memorizes all addresses and returns an error for calls it never seen before. | ||
| func (m *stakingKeeperStub) GetValidator(ctx context.Context, addr sdk.ValAddress) (stypes.Validator, error) { |
There was a problem hiding this comment.
Suggested change
| func (m *stakingKeeperStub) GetValidator(ctx context.Context, addr sdk.ValAddress) (stypes.Validator, error) { | |
| func (m *stakingKeeperStub) GetValidator(_ context.Context, addr sdk.ValAddress) (stypes.Validator, error) { |
kc1116
reviewed
Nov 29, 2024
Comment on lines
+313
to
315
| m.validators[hexAddr] = true | ||
|
|
||
| return stypes.Validator{}, errors.New("validator does not exist") |
There was a problem hiding this comment.
A bit confused by this, we set the validator to true but we return an error?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More unit tests for unhappy paths.
issue: #2525