Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support list append from command line and config file #138

Merged
merged 5 commits into from
May 24, 2022
Merged

Conversation

mauvilsa
Copy link
Member

Closes #85.

@mauvilsa
Copy link
Member Author

@carmocca can you please review. Mostly to look at the unit tests in case you observe any important use cases that I forgot to add.

@lgtm-com
Copy link

lgtm-com bot commented May 23, 2022

This pull request introduces 1 alert when merging ab0163a into 8506d79 - view on LGTM.com

new alerts:

  • 1 for Unused import

Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this!

jsonargparse_tests/typehints_tests.py Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented May 23, 2022

This pull request fixes 1 alert when merging e0fa7b9 into 8506d79 - view on LGTM.com

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

@sonarcloud
Copy link

sonarcloud bot commented May 23, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lgtm-com
Copy link

lgtm-com bot commented May 23, 2022

This pull request fixes 1 alert when merging 162c1a4 into 8506d79 - view on LGTM.com

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

@mauvilsa mauvilsa merged commit 09ed681 into master May 24, 2022
@mauvilsa mauvilsa deleted the issue-85 branch May 24, 2022 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support passing lists of class_path items via command line
2 participants