Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the develop-1.x branch to the master-1.x branch #175

Merged
merged 2 commits into from
Dec 26, 2018

Conversation

akolotov
Copy link
Collaborator

@akolotov akolotov commented Dec 26, 2018

@ghost ghost assigned akolotov Dec 26, 2018
@netlify
Copy link

netlify bot commented Dec 26, 2018

Deploy preview for kind-kilby-95344f processing.

Built with commit 1f93798

https://app.netlify.com/sites/kind-kilby-95344f/deploys/5c23bb70fba43700086a71b4

@akolotov
Copy link
Collaborator Author

@patitonar could you take a look why the build failed?

@patitonar
Copy link

@akolotov The build is failing because of the e2e tests. The 1.x version e2e tests uses a deployed rust bridge on Sokol-Kovan. It seems that the bridge is not working anymore so every PR to this version will fail. You can check details on the Netlify preview https://5c23bb70fba43700086a71b4--kind-kilby-95344f.netlify.com/

Current version of Bridge UI use Docker to run private parity chains, deploy contracts, run token-bridge and run e2e tests agains that bridge.

@akolotov
Copy link
Collaborator Author

@patitonar thanks for info. Will merge the branch then. Could you monitor http://bridge.poa.network for few minutes after deployment that will happen after the merge? We need to make sure that it was deployed successfully.

@akolotov akolotov merged commit 70bd6cd into master-1.x Dec 26, 2018
@ghost ghost removed the review label Dec 26, 2018
@patitonar
Copy link

@akolotov Does the deploy to http://bridge.poa.network need a manual step? or should it deploy automatically after merging to master-1.x?

@patitonar
Copy link

If it should be automatically, then the deploy didn't happen because the app is still using poaexplorer.com url on the links.

@akolotov
Copy link
Collaborator Author

@patitonar asked Igor to take a look at the netlify configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants