breaking change in last web3js release. fix dep. #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for kind-kilby-95344f processing. Building with commit a49de49 https://app.netlify.com/sites/kind-kilby-95344f/deploys/5c4f19a4979f000008a5d1ab |
akolotov
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last webjs introduce breaking change on existing code.
For instance, v1.0.0-beta.38 remove utils here :
web3/web3.js@cfd9130
and it breaks the following code :
https://github.com/poanetwork/bridge-ui/blob/develop/src/stores/utils/gas.js#L1
It seems, I have also have an issue with .call format change here from a string to an object and break the switch condition here :
https://github.com/poanetwork/bridge-ui/blob/develop/src/stores/utils/bridgeMode.js#L33
as value bridgeModeHash show in the picture :
I fix by targeting strict version :
"web3": "1.0.0-beta.30"instead of :"web3": "^1.0.0-beta.30".Maybe a specific future web3js update to treat.