Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build-css step on build script #187

Merged
merged 1 commit into from
Feb 22, 2019
Merged

Conversation

patitonar
Copy link

Right now if you want to add/change a css style, you have to update the corresponding .scss file, then run npm run build-css to generate the compiled css file src/assets/stylesheets/application.css and then it need to be included in git with the rest of the changes since the react app uses that file to apply the styles. This can be confusing specially for new contributors (see this comment)

This PR removes the application.css file from git and updates start and build scripts to run build-css as a first step so the file application.css will be generated before the react app builds.

So after these changes, changing a css style will only require updating the .scss file

@netlify
Copy link

netlify bot commented Feb 21, 2019

Deploy preview for kind-kilby-95344f processing.

Building with commit 73dcdf6

https://app.netlify.com/sites/kind-kilby-95344f/deploys/5c6ec14edb27110008db85cc

@coveralls
Copy link

Pull Request Test Coverage Report for Build 334

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 3.232%

Totals Coverage Status
Change from base Build 328: 0.0%
Covered Lines: 46
Relevant Lines: 1090

💛 - Coveralls

@akolotov akolotov merged commit 976890c into develop Feb 22, 2019
@ghost ghost removed the review label Feb 22, 2019
@akolotov akolotov deleted the Add-build-css-on-build-script branch May 24, 2019 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants