Add build-css step on build script #187
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if you want to add/change a css style, you have to update the corresponding
.scss
file, then runnpm run build-css
to generate the compiled css filesrc/assets/stylesheets/application.css
and then it need to be included in git with the rest of the changes since the react app uses that file to apply the styles. This can be confusing specially for new contributors (see this comment)This PR removes the
application.css
file from git and updatesstart
andbuild
scripts to runbuild-css
as a first step so the fileapplication.css
will be generated before the react app builds.So after these changes, changing a css style will only require updating the
.scss
file