Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support transaction null status #189

Merged
merged 2 commits into from
Mar 13, 2019
Merged

Conversation

patitonar
Copy link

If status attribute is not present on transaction receipt, it will also check on the length of logs attribute to determine that the transaction was successful

@netlify
Copy link

netlify bot commented Feb 28, 2019

Deploy preview for kind-kilby-95344f processing.

Building with commit d9db5a4

https://app.netlify.com/sites/kind-kilby-95344f/deploys/5c867b9aef49d30008786b21

@coveralls
Copy link

coveralls commented Feb 28, 2019

Pull Request Test Coverage Report for Build 345

  • 4 of 5 (80.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.7%) to 4.897%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/stores/TxStore.js 4 5 80.0%
Totals Coverage Status
Change from base Build 341: 1.7%
Covered Lines: 71
Relevant Lines: 1081

💛 - Coveralls

@ghost ghost added the in progress label Mar 11, 2019
@akolotov akolotov merged commit 17fe309 into develop Mar 13, 2019
@ghost ghost removed the in progress label Mar 13, 2019
@akolotov akolotov removed the review label Mar 13, 2019
@akolotov akolotov deleted the support-transaction-null-status branch May 24, 2019 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants