Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade node version to 10.15 #191

Merged
merged 2 commits into from
Mar 22, 2019
Merged

upgrade node version to 10.15 #191

merged 2 commits into from
Mar 22, 2019

Conversation

patitonar
Copy link

Updated .nvmrc and dockerfile to use version 10.

Also npm vulnerabilities were fixed, now npm audit report shows only 31 vulnerabilities that are related to dependencies of react-scripts. Upgrading react-scripts introduce some breaking changes to react-app-rewired and react-app-rewire-mobx which will require some configuration updates (and possibly a new dependency). Given that react-scripts is used to avoid configuration for development and build process I think it's ok for now to have these vulnerabilities.

found 31 vulnerabilities (29 low, 2 high) in 105330 scanned packages
  31 vulnerabilities require semver-major dependency updates.

Closes #177

@patitonar patitonar requested a review from akolotov March 11, 2019 18:49
@ghost ghost assigned patitonar Mar 11, 2019
@ghost ghost added the review label Mar 11, 2019
@netlify
Copy link

netlify bot commented Mar 11, 2019

Deploy preview for kind-kilby-95344f processing.

Building with commit 7bd5772

https://app.netlify.com/sites/kind-kilby-95344f/deploys/5c94ef059e64510008672c89

@coveralls
Copy link

coveralls commented Mar 11, 2019

Pull Request Test Coverage Report for Build 383

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 13 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+1.7%) to 4.897%

Files with Coverage Reduction New Missed Lines %
src/stores/TxStore.js 13 13.39%
Totals Coverage Status
Change from base Build 341: 1.7%
Covered Lines: 71
Relevant Lines: 1081

💛 - Coveralls

Copy link
Collaborator

@akolotov akolotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you elaborate why the netlify deploy was failed?

@ghost ghost removed the in progress label Mar 22, 2019
@akolotov akolotov merged commit 346452a into develop Mar 22, 2019
@ghost ghost removed the review label Mar 22, 2019
@patitonar
Copy link
Author

Netlify deploy failed because submodule repo didn't support Node 10. After updating to latest commit on 119-Epic-rewards-for-bridge-validators build now is working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants