Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of absence eth_chainId on Web3 provider side #207

Merged
merged 2 commits into from
Mar 29, 2019

Conversation

akolotov
Copy link
Collaborator

If a web3 provider used by the wallet does not support eth_chainId call the message Wallet account rejected by user. You need to unlock your wallet. Please refresh the page and click 'Connect' button in your wallet popup appears. It does not clarify the issue.

That's why it is suggested to handle errors appeared when getChainId called and provide more precise explanation what it is necessary to do to address the issue.

@netlify
Copy link

netlify bot commented Mar 28, 2019

Deploy preview for kind-kilby-95344f processing.

Building with commit 47c232a

https://app.netlify.com/sites/kind-kilby-95344f/deploys/5c9e01c79e88e3000864f322

@coveralls
Copy link

coveralls commented Mar 28, 2019

Pull Request Test Coverage Report for Build 438

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 10.292%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/stores/utils/web3.js 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
src/stores/utils/web3.js 1 0.0%
Totals Coverage Status
Change from base Build 436: -0.03%
Covered Lines: 48
Relevant Lines: 445

💛 - Coveralls

src/stores/utils/web3.js Outdated Show resolved Hide resolved
@ghost ghost added the in progress label Mar 29, 2019
@akolotov akolotov merged commit a032b6b into omni:develop Mar 29, 2019
@ghost ghost removed the in progress label Mar 29, 2019
@akolotov akolotov removed the review label Mar 29, 2019
@akolotov akolotov deleted the web3provider-wo-chainid branch March 29, 2019 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants