Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALM: Do not show failed confirmations for successfully processed messages #641

Merged
merged 1 commit into from
Mar 13, 2022

Conversation

k1rill-fedoseev
Copy link
Member

No description provided.

@k1rill-fedoseev k1rill-fedoseev requested a review from akolotov March 5, 2022 19:45
@k1rill-fedoseev k1rill-fedoseev self-assigned this Mar 5, 2022
Copy link
Collaborator

@akolotov akolotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the requirement for this ALM enhancement: #642. Please pay attention that Success is changed to Confirmed and how meaning of Fail was changed.

@akolotov akolotov merged commit 9c2d2f4 into develop Mar 13, 2022
@akolotov akolotov deleted the alm-skip-failed branch March 13, 2022 10:55
akolotov added a commit that referenced this pull request Mar 18, 2022
This merge contains the following set of changes:
  * [Oracle, Improvement] Helpers for overriding AMB signatures (#640)
  * [Oracle, Improvement] Support manual signatures in erc to native mode (#646)
  * [ALM, Improvement] ALM: Do not show unneeded failed confirmations (#641)
  * [ALM, Improvement] ALM: warning for auto-relayed messages (#644)
  * [ALM, Fix] ALM: reorder warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants