-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump pyemma 2.3 #662
bump pyemma 2.3 #662
Conversation
@jchodera What has changed with the holy build box image? The build fails because mdtraj can not find the libcxx version it depends on:
|
the windows build is broken for an unknown error: |
Thanks for the hint. So we have to build on conda-forge and then upload to omnia, like mdtraj did before? |
or just disable the import test... great. |
IIRC the intention is to move as much as possible over to conda-forge and away from omnia. |
Yes. We can also directly stop to support it. Our packages are already there. |
You might consider just removing the recipe from here then, as @mpharrigan did for MDTraj. https://github.com/omnia-md/conda-recipes/tree/master/mdtraj |
@marscher , if your packages are on conda-forge, you can copy the binaries over to omnia without rebuilding them https://docs.continuum.io/anaconda-cloud/cli#copy A lot of documentation has |
with the neat side effect of breaking the assumptions of the compatibility of this channel. Why it was not considered to just copy the conda-forge recipe here and let the build system do the rest? Or was it broken (again)? The only downside of conda-forge is its slowness (eg. the Appveyor queue takes ~3 days per commit) |
Luckily, the only compatibility issues that have been reported have been with the omnia build box and not with any users. Yes, we are increasing the system requirements from centos 5 (eol in < 2 months) to centos 6. We're easing over to conda-forge like this:
|
@marscher: I think your comment "Or was it broken (again)?" reflects the core reason for moving to conda-forge, despite the trickiness in the interim period that we're seeing. The maintenance burden of keeping the omnia build system humming is pretty high (thus it being frequently broken), and will be reduced substantially with conda-forge because of the wider community adoption. |
I think everyone wants to to do this, but the dependencies limit us to a plan that is roughly:
The mdtraj experiment with migrating to conda-forge was just too early, and we'll just need to restore the recipe in Omnia in order to avoid these problems from happening over and over again until we're doing CentOS 6 based builds for omnia as well. @mpharrigan and @rmcgibbo : I'd like to restore the MDTraj recipe into omnia for now. Can you help, or should I take a stab at it? |
Hi John, Not all packages depend on OpenMM. For example, mdtraj and pyemma :)
I think it would be a mistake to (1) wait for this (appears to be stalled) and (2) reconfigure our whole build system instead of using the system conda-forge has set up
I think removing the automated import test is a small price to pay for forward progress. In this particular case, @marscher already has conda-forge binaries that have been import tested. We can copy those over to the omnia label for backwards compatibility with |
No, but many do, and many also depend on mdtraj and pyemma, so having mdtraj break things (like this) is problematic at this point.
Moving Updating to a CentOS 6-based holy-build-box is simply the easiest way (in terms of labor) for us to migrate
We run the risk of building packages that don't work and causing lots of pain as a result, since we have no way of strictly enforcing everyone testing their packages separately. And once pyemma moves over, it's going to break something else that uses pyemma, and so on, and so on. Eventually, most packages will be forced to migrate except for those dependent on openmm, which are stuck until we get that built on conda-forge, which won't be trivial. There's a logical way to do this migration, which is as I outlined. But the "defect early, don't care if we screw others" model is not really helping. |
That said, @mpharrigan, if you'd like to put in the effort to create a new set of omnia-build-box docker images (maybe create a different repo, |
I can not build pyemma anymore on Omnia, because we need mdtraj already
at build time (minRMSD metric for clustering algorithms). So I copied
over the packages from conda-forge as suggested.
As long as people don't want to use our software on clusters with fairly
old operating systems, we're fine. But can we know this for sure?
I guess it is not much effort to just copy the mdtraj recipe from
conda-forge and we will simply avoid this trouble. We should set up a
proper migration plan soon, which works for all packages.
|
There are a few simple solutions to this. @marscher : Do you really use mdtraj >= 1.8 features? If not, we can simply delete the 1.7 package from the Alternatively, I'm preparing a PR to temporarily restore mdtraj 1.8 builds to omnia until someone is willing to put in the effort to update our docker build containers to CentOS 6. |
No description provided.