-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Move to Centos 6 builds #3
Conversation
Comments from #2:
Fixed
I thought I had removed the section that installed python from source?
Nope, but will do so. Cheers, |
Thanks, looking good so far. You should also update the documentation section about which Linux distros are compatible with the produced binaries. One thing you may want to take care of. CentOS 5's OpenSSL did not support SNI, so the curl in CentOS 5 fails to download from many HTTPS servers. In order to solve this, our Docker build script downloads OpenSSL and curl over plain HTTP, and builds them, so that later on in the script we can actually download tarballs over HTTPS. This workaround is probably no longer necessary with the OpenSSL and curl version included in CentOS 6, so you may want to look at making the build script shorter. |
@FooBarWidget How attached to 32 bit builds are you? It looks like the devtoolsets no longer support 32 bit (there aren't i386 repos). This would mean that for 32bit builds, one would need to compiler gcc et al. from source. Could we drop 32 bit support going forward, with 32 bit users still being able to use the 32 bit centos 5 images? |
@@ -16,7 +16,7 @@ function activate_holy_build_box_deps_installation_environment() { | |||
export CPPFLAGS=-I/hbb/include | |||
export LDPATHFLAGS="-L/hbb/lib -Wl,-rpath,/hbb/lib" | |||
export LDFLAGS="$LDPATHFLAGS" | |||
export LD_LIBRARY_PATH=/hbb/lib | |||
export LD_LIBRARY_PATH=/hbb/lib:${LD_LIBRARY_PATH} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should put this assignment inside quotes, like this:
export LD_LIBRARY_PATH="/hbb/lib:${LD_LIBRARY_PATH}"
Otherwise bash won't handle things properly if the old LD_LIBRARY_PATH contains special characters, like multiple spaces.
We at Phusion aren't very attached. It seems only about 0.9% of our binaries downloads are for x86. But I don't know about other Holy Build Box users. How much trouble would it be to compile GCC ourselves? If it's not too much trouble then I'd rather keep x86 support. But if the time investment is disproportionally big then we have to reevaluate. |
We also dropped 32bit binaries, but the source code is still 32bit compliant. I tried the image from
Apparently, /hbb/bin/python is missing and libcheck requires that (small fix): # Activate Holy Build Box environment.
source /hbb_exe/activate
# Fix python path in /hbb/bin/python
ln -s `which python` /hbb/bin/python |
@FooBarWidget I'm tempted to drop support for 32 bit binaries (at least initially). |
This is a work in progress, and will address #2
@FooBarWidget : I'll remove the "WIP" tag from the title of the PR and comment here when ready for review.