Map userinfo fix #17
Merged
Map userinfo fix #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Net::LDAP::Entry returns empty array if key not exists, so we should check for key with respond_to?
|
Why this is not merged? |
|
+1 on this, cost me a lot of time when setting up LDAP authentication for GitLab with an AD server. |
|
@retiolum I'll merge if I have a PR that will cleanly merge into master. I'm not really the active maintainer here, but happy to pull it in. |
|
why this not merged? gitlab software having problem with LDAP with legacy active directory authorization because this array doesn't rotate, can somebody accept this merge please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Net::LDAP::Entry (http://net-ldap.rubyforge.org/Net/LDAP/Entry.html) returns empty array if key does not
exists, so object[:some_symbol] always returned true, which could cause empty fields in userinfo if field had some other name, than the first in mapping array ('email' => 'mail', for example).