Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please support ValidUntil and cacheDuration support on Metadata #198

Open
nijel opened this issue Jan 28, 2021 · 0 comments
Open

Please support ValidUntil and cacheDuration support on Metadata #198

nijel opened this issue Jan 28, 2021 · 0 comments

Comments

@nijel
Copy link

nijel commented Jan 28, 2021

It has been added in SAML-Toolkits/ruby-saml@92d6caf (see SAML-Toolkits/ruby-saml#563).

Without specifing that the SAML medatada generated by omniauth-saml violate the SAML 2.0 specification because it doesn't include validUntil or cacheDuration attribute on the root EntityDescriptor element. It also doesn't provide an interface to define this by the application.

The specification is clear that it should be present at the root EntityDescriptor element.

When used as the root element of a metadata instance, this element MUST contain either a validUntil or cacheDuration attribute.

Both validUntil and cacheDuration of the EntityDescriptor element are optional in the specification because they should appear only on the root element and are not recommended to use elsewhere and the EntityDescriptor element doesn't have to be a root element.

Related issues:

CC @thorsteneckel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant