Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interface to define validUntil/cacheDuration #563

Closed
nijel opened this issue Jan 4, 2021 · 1 comment
Closed

Add interface to define validUntil/cacheDuration #563

nijel opened this issue Jan 4, 2021 · 1 comment

Comments

@nijel
Copy link

nijel commented Jan 4, 2021

The SAML medatada generated by ruby-saml violate the SAML 2.0 specification because it doesn't include validUntil or cacheDuration attribute on the root EntityDescriptor element. It also doesn't provide an interface to define this by the application.

The specification is clear that it should be present at the root EntityDescriptor element.

When used as the root element of a metadata instance, this element MUST contain either a validUntil or cacheDuration attribute.

Both validUntil and cacheDuration of the EntityDescriptor element are optional in the specification because they should appear only on the root element and are not recommended to use elsewhere and the EntityDescriptor element doesn't have to be a root element.

Related issues:

@pitbulk
Copy link
Collaborator

pitbulk commented Jan 26, 2021

Will be available on 1.12.0
92d6caf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants