Allow some logout parameters to be used #207
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mainly to add the ones from the OpenID Connect specs (client_id, id_token_hint, state, ui_locales, logout_hint), but others could be added too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly to add the logout parameters from the OpenID Connect specs (client_id, id_token_hint, state, ui_locales, logout_hint).
But other parameters could be added too since it seems to be different for some OpenID Providers, cf. Amazon Cognito.
I am using Keycloak and it seems to require the
id_token_hintwhen thepost_logout_redirect_uriis passed.PS: I tried to use the patch from #149 but it didn't work since I am using the Authorization Code flow and I couldn't access the access_token afterwards, so I will pass it as a request parameter of the logout path.
PS 2: I didn't understand the purpose of the
id_token_hintoption within the library, so I totally skip using it. By the way, when I search for it, it was only defined as an optional parameter for Rack::OAuth2 in the Server part (and not the Client part which this library is for).