fix(xtask): Correct version prefix to include 'v' #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the version comparison against what's expected by `git-cliff`, we have to do some version string parsing, and this involves stripping a prefix off which specifies the crate to _only_ get the actual version number triple portion. The prior prefix used was missing the letter "v" which is part of the prefix, and so parsing failed in practice. This commit adds the missing part of the prefix. Signed-off-by: Andrew Lilley Brinker <alilleybrinker@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the version comparison against what's expected by
git-cliff, wehave to do some version string parsing, and this involves stripping
a prefix off which specifies the crate to only get the actual
version number triple portion. The prior prefix used was missing the
letter "v" which is part of the prefix, and so parsing failed in
practice. This commit adds the missing part of the prefix.