fix(xtask): Don't quote CHANGELOG commit message. #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, in the "commit-changelog" step of the `cargo xtask release` command, we'd wrap the commit message in quotes. Turns out this is processed by Git in a way that means the actual commit message header is committed wrapped in quotes, which means it won't parse as a conventional commit, and also that it breaks rollback (because rollback checks commit messages to ensure it doesn't actually un-commit the wrong thing). This commit removes the quote wrapping, which should ensure correct parsing _and_ avoid broken rollback. Signed-off-by: Andrew Lilley Brinker <alilleybrinker@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, in the "commit-changelog" step of the
cargo xtask releasecommand, we'd wrap the commit message in quotes. Turns out this is
processed by Git in a way that means the actual commit message header
is committed wrapped in quotes, which means it won't parse as a
conventional commit, and also that it breaks rollback (because
rollback checks commit messages to ensure it doesn't actually un-commit
the wrong thing).
This commit removes the quote wrapping, which should ensure correct
parsing and avoid broken rollback.
Signed-off-by: Andrew Lilley Brinker alilleybrinker@gmail.com