Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Combobox input value change composition #95

Merged
merged 26 commits into from
Jun 24, 2024

Conversation

coopbri
Copy link
Contributor

@coopbri coopbri commented Jun 22, 2024

Description

Task link: N/A
  • Added knip (and fixed corresponding reported issues)
  • Removed default placeholder on Select and Combobox
  • Integrated support for Combobox onInputValueChange handler composition with the built-in filtering callback
  • Fixed Panda style props not being injected into component props

Test Steps

  • Verify passing Combobox an input value change handler (onInputValueChange) does not override the built-in filtering behavior, but rather composes it. The Combobox should filter results as expected and also compose any custom logic
  • Verify Select and Combobox default placeholders are removed
  • Verify all components properly support Panda JSX style props statically (TS)

Copy link

changeset-bot bot commented Jun 22, 2024

🦋 Changeset detected

Latest commit: 99cf634

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@omnidev/sigil Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jun 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sigil-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 4:01am

@coopbri coopbri marked this pull request as ready for review June 24, 2024 04:03
@coopbri coopbri merged commit bd9628a into master Jun 24, 2024
3 checks passed
@coopbri coopbri deleted the fix/combobox-input-value-change-composition branch June 24, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant