Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

colour regressions #34

Closed
nebulon42 opened this issue Apr 29, 2016 · 2 comments · Fixed by #35
Closed

colour regressions #34

nebulon42 opened this issue Apr 29, 2016 · 2 comments · Fixed by #35

Comments

@nebulon42
Copy link
Contributor

Some regressions with my colour implementation were recently fixed in carto. These are very likely also present here.

What I have identified is that the mix function should definitely operate on RGB as operating on HSL/HUSL will yield different results. I'm not sure if the possibility to add/subtract colours is even present here.

Refs:
mapbox/carto#441
mapbox/carto#442
mapbox/carto#443
@olt
Copy link
Member

olt commented Apr 29, 2016

Ok, can you "revert" the change?

Add/subtract is not implemented right now and I don't think we actually need this. Compatibility with carto is a goal, but not 100% by all means.

@nebulon42
Copy link
Contributor Author

Right, I will try to provide a fix for the mix function.

nebulon42 added a commit to nebulon42/magnacarto that referenced this issue Apr 30, 2016
@nebulon42
fix colour regressions by moving Multiply and Mix to RGB space again,…
fe65e7e 
… add test cases (fixes omniscale#34
@nebulon42 nebulon42 mentioned this issue Apr 30, 2016
Merged
@olt olt closed this as completed in #35 Jun 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix colour regressions nebulon42/magnacarto
2 participants
@olt @nebulon42