Contact sync #26
Merged
Contact sync #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnas
reviewed
Feb 20, 2024
| $users = $wp_user_query->get_results(); | ||
|
|
||
| if ( empty( $users ) ) { | ||
| wp_clear_scheduled_hook( OMNISEND_CORE_CRON_SYNC_CONTACT ); |
There was a problem hiding this comment.
It is normal situation when all users are synced. We decided do not have UI and plugin does not have logs like Woo plugin. What log and where you expect?
There was a problem hiding this comment.
maybe adding logs now will save us time later, when we would introduce logs in UI.
There was a problem hiding this comment.
I was thinking about that, but decided not to do, as this will increase scope. Let's leave for later.
rokeras
reviewed
Feb 20, 2024
rokeras
reviewed
Feb 20, 2024
rokeras
reviewed
Feb 20, 2024
rokeras
previously approved these changes
Feb 20, 2024
Co-authored-by: Rokas Paičius <rokas.p@omnisend.com>
Co-authored-by: Rokas Paičius <rokas.p@omnisend.com>
rokeras
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://omnisend.atlassian.net/browse/INT-813