Patch-API: avoid committing on GET endpoints #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fschuch
force-pushed
the
patch(api)-avoid-commiting-in-get-endpoints
branch
from
c5561ba to
4eccdfa
Compare
matheushent
approved these changes
Oct 12, 2023
omnivector-qa
pushed a commit
that referenced
this pull request
Oct 12, 2023
(cherry picked from commit b9f7e5e)
fschuch
added a commit
that referenced
this pull request
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR applies a simple patch in the API code to avoid running
session.commit()against the database while only read queries are run.Porting changes from omnivector-solutions/license-manager#284
Why
Enhance and track performance.
Peer Review
Please follow the upstream omnivector documentation concerning
peer-review guidelines.