Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASP-4070] Distinguish application-id, job-script-id and job-submission-id #399

Merged
merged 8 commits into from
Oct 27, 2023

Conversation

julianaklulo
Copy link
Contributor

What

Add alias to application-id, job-script-id and job-submission-id to distinguish each other when submitting a job.

Why

All of them were displayed as id, which was confusing the users.

Task: https://jira.scania.com/browse/ASP-4070


Peer Review

Please follow the upstream omnivector documentation concerning
peer-review guidelines.

Copy link
Member

@matheushent matheushent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the point of distinguishing this way? IMO it just adds redundancy.

EDIT

I understand the confusion for users. Disregard my comment

Copy link
Member

@fschuch fschuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, I left a few comments

jobbergate-cli/CHANGELOG.md Outdated Show resolved Hide resolved
jobbergate-cli/jobbergate_cli/schemas.py Show resolved Hide resolved
@julianaklulo julianaklulo merged commit a59ade1 into main Oct 27, 2023
4 checks passed
@julianaklulo julianaklulo deleted the ASP-4070--distinguish-ids branch October 27, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants