Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASP-4238] Add on-site submission support #427

Merged
merged 4 commits into from
Nov 30, 2023

Conversation

fschuch
Copy link
Member

@fschuch fschuch commented Nov 29, 2023

What

  • Add support for on-site submissions:
    • SBATCH_PATH is set on the CLI, so it is expected to download job-script files, submit them to slurm using sbatch, and include slurm_job_id on the payload to create a new submission.
    • The API processes the creation giving it the status SUBMITTED and adding the new entry on the database. No need to parse any job-property, since all #SBATCH directives were processed at submission time by sbatch.
    • These jobs won't be processed as pending by the agent since their status is not CREATED, remember it was already submitted.
    • Like on remote submissions, the agent will keep track of active jobs (STATUS=SUBMITTED) and update them as needed.

Why

As a Jobbergate maintainer, I want to add support for on-site submissions to the next-gen Jobbergate, so that it can operate with feature parity compared to the legacy system, thereby facilitating user-base migration. Meanwhile, current support for remote submissions will remain undisturbed.

Task: https://jira.scania.com/browse/ASP-4238


Peer Review

Please follow the upstream omnivector documentation concerning
peer-review guidelines.

Copy link
Member

@dusktreader dusktreader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment for you. Nice work!

@fschuch fschuch merged commit 02d09b5 into main Nov 30, 2023
4 checks passed
@fschuch fschuch deleted the fschuch/ASP-4238--add-on-site-submission-support branch November 30, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants