Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PENG-2426 Added upload-by-url endpoints #635

Conversation

dusktreader
Copy link
Member

Added endpoints to upload by url for:

  • Job Script Files
  • Job Script Template Files
  • Job Script Template Workflow Files

Also added unit tests.

Task: https://app.clickup.com/t/18022949/PENG-2426

Peer Review

Please follow the upstream omnivector documentation concerning
peer-review guidelines.

Added endpoints to upload by url for:
* Job Script Files
* Job Script Template Files
* Job Script Template Workflow Files

Also added unit tests.
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.21%. Comparing base (273dfe3) to head (2e0afd8).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #635      +/-   ##
==========================================
+ Coverage   92.09%   92.21%   +0.12%     
==========================================
  Files          83       83              
  Lines        4426     4485      +59     
==========================================
+ Hits         4076     4136      +60     
+ Misses        350      349       -1     
Flag Coverage Δ
agent 92.82% <ø> (ø)
api 95.30% <ø> (+0.21%) ⬆️
cli 87.70% <ø> (ø)
core 96.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@matheushent matheushent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Just got a comment regarding an addition

@fschuch fschuch self-requested a review October 18, 2024 20:14
Copy link
Member

@fschuch fschuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple comments. Please, add a new entry on the changelog file.

@dusktreader
Copy link
Member Author

I left a couple comments. Please, add a new entry on the changelog file.

Addressed in commit 87e0887

@dusktreader dusktreader merged commit b8ead1e into main Oct 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants