-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PENG-2426 Added upload-by-url endpoints #635
PENG-2426 Added upload-by-url endpoints #635
Conversation
Added endpoints to upload by url for: * Job Script Files * Job Script Template Files * Job Script Template Workflow Files Also added unit tests.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #635 +/- ##
==========================================
+ Coverage 92.09% 92.21% +0.12%
==========================================
Files 83 83
Lines 4426 4485 +59
==========================================
+ Hits 4076 4136 +60
+ Misses 350 349 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Just got a comment regarding an addition
jobbergate-api/jobbergate_api/apps/job_script_templates/routers.py
Outdated
Show resolved
Hide resolved
jobbergate-api/jobbergate_api/apps/job_script_templates/routers.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple comments. Please, add a new entry on the changelog file.
Addressed in commit 87e0887 |
Added endpoints to upload by url for:
Also added unit tests.
Task
: https://app.clickup.com/t/18022949/PENG-2426Peer Review
Please follow the upstream omnivector documentation concerning
peer-review guidelines.