-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ASP-5649] Enable positional arguments on "get-one" commands on Jobbergate-cli #636
[ASP-5649] Enable positional arguments on "get-one" commands on Jobbergate-cli #636
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #636 +/- ##
==========================================
+ Coverage 92.09% 92.54% +0.44%
==========================================
Files 83 84 +1
Lines 4426 4478 +52
==========================================
+ Hits 4076 4144 +68
+ Misses 350 334 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool work, here. Added some comments for you.
d172cee
to
33777a8
Compare
What
All the Jobbergate commands that select one entry do it by command line options like
--id
, or--identifier
, for instance:Since the identification is required when selecting a given entry, it can be changed to a positional argument. In this way, it can be provided right after the command with no need to type
--id
or--identifier
every time. For instance:This was just an example on
jobbergate applications get-one
, but this enhancement can also be extended to many other commands.Why
As a Jobbergate user, I want a simplified way to select entries on the jobbergate commands, so that my experience using the cli is less typing intensive.
Task
: https://jira.scania.com/browse/ASP-5649Peer Review
Please follow the upstream omnivector documentation concerning
peer-review guidelines.