Implement an interface from fetching job metrics from InfluxDB #663
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/PENG-2455--job-metric-collection #663 +/- ##
============================================================================
+ Coverage 92.57% 92.68% +0.10%
============================================================================
Files 85 87 +2
Lines 4483 4632 +149
============================================================================
+ Hits 4150 4293 +143
- Misses 333 339 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…fluxDB and send it to the API
matheushent
force-pushed
the
matheushent/PENG-2457--job-metric-collection--agent
branch
from
01fb385 to
71d3ffd
Compare
| msgpack = "^1.1.0" | ||
| influxdb = "^5.3.2" |
There was a problem hiding this comment.
I think these two guys could be optional dependencies. On initialize_influx_client, unsure to cover ImportError if metrics are enabled but dependencies are not installed.
There was a problem hiding this comment.
that would require the logistical part of setting up the agent to install these dependencies. I think that, for running the agent easily, it's better to leave as is
There was a problem hiding this comment.
I had no auto installation in mind, at installation time they could be included with pip install jobbergate-agent[metrics], for instance. But at the same time it is not a big deal, it is more a suggestion.
There was a problem hiding this comment.
I wonder how that would be customizable in the snap. I'd had to spend a bit of time on that
…umba instead of vanilla Python. As well as, create a module specific for compute related operations.
matheushent
changed the base branch from
main
to
feature/PENG-2455--job-metric-collection
…ding the metrics to the API
…a structure expected by the API
…ergate_agent/jobbergate/schemas.py*
…_success* unit test
matheushent
merged commit 179f0ec
into
feature/PENG-2455--job-metric-collection
matheushent
deleted the
matheushent/PENG-2457--job-metric-collection--agent
branch
What
This PR implement the necessary code in the Jobbergate Agent and its Snap to enable job metric collection from InfluxDB.
The implementation involves a settings parameter which is used for connecting to InfluxDB. The logic happens during the
active_submissions_tasktask. If any part of the upload of metrics of an active job submission fails, it won't interrupt the execution.Once fetched the metrics for an active job submission, the agent sends to the API.
Why
Provide insights regarding jobs through the API.
Task: https://sharing.clickup.com/t/h/c/18022949/PENG-2457/BU7UOA63B936N27Peer Review
Please follow the upstream omnivector documentation concerning
peer-review guidelines.