fix(agent): PENG-2457 defer sending data to the API in case there's no new data #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o new data This commit introduces a change in the *update_job_metrics* function so the API call to insert new metrics is deferred in case there's no new metric, i.e. the list of metrics is empty.
matheushent
force-pushed
the
task/PENG-2457-defer-when-no-metric-is-available
branch
from
bbfcec9 to
c391f16
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/PENG-2455--job-metric-collection #681 +/- ##
===========================================================================
Coverage ? 92.83%
===========================================================================
Files ? 88
Lines ? 4844
Branches ? 0
===========================================================================
Hits ? 4497
Misses ? 347
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fschuch
approved these changes
Dec 20, 2024
matheushent
merged commit 3555fe0
into
feature/PENG-2455--job-metric-collection
13 checks passed
matheushent
deleted the
task/PENG-2457-defer-when-no-metric-is-available
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a change in the update_job_metrics function so the API call to insert new metrics is deferred in case there's no new metric, i.e. the list of metrics is empty.
Peer Review
Please follow the upstream omnivector documentation concerning
peer-review guidelines.