Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve local redis and docker build errors #4437

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rbarbazz
Copy link
Contributor

@rbarbazz rbarbazz commented Oct 24, 2024

I encountered a couple of issues when running the app locally, which this PR addresses:

  1. Fix for MacBook M1 build issue (commit: 81dbcca, closes #3315):

  2. Fix for Redis connection error (commit: f7ae2a4):

    • While running docker compose up api content-fetch, I encountered this error:
      omnivore-api            | [ioredis] Unhandled error event: Error: connect ENOENT %27redis://redis:6379%27
      omnivore-api            |     at PipeConnectWrap.afterConnect [as oncomplete] (node:net:1494:16)
    • Removing the single quotes around the default REDIS_URL fixed the issue.
      Edit: I just noticed there's already another PR that implements this fix fix: Quoted redis url in compose causing error #4378, happy to revert.

Copy link

vercel bot commented Oct 24, 2024

@rbarbazz is attempting to deploy a commit to the omnivore Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERROR [api builder 23/26] RUN yarn workspace @omnivore/api build
1 participant