Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the outcomes module to be called as an extension #31

Merged
merged 1 commit into from
Jan 27, 2015

Conversation

Tape
Copy link
Collaborator

@Tape Tape commented Jan 27, 2015

These changes are all non-breaking api-wise so this can be merged without issue as long as the changes seem to be sound.

@Tape
Copy link
Collaborator Author

Tape commented Jan 27, 2015

I looked into the error that is being thrown for the node 0.11.x test and it seems that in a recent version they introduced a breaking change where if path is present in a url to be formatted that takes priority over the query string, I will attempt to fix the issue in a separate PR since the module is unrelated to this one.

nodejs/node-v0.x-archive#9070

@Tape Tape force-pushed the outcomes-as-extension branch from 5a3db2e to 26afb39 Compare January 27, 2015 18:37
Tape pushed a commit that referenced this pull request Jan 27, 2015
Refactor the outcomes module to be called as an extension
@Tape Tape merged commit fb10674 into master Jan 27, 2015
@Tape Tape deleted the outcomes-as-extension branch January 27, 2015 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant