Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change identifier variable from identifier to _id #62

Merged
merged 1 commit into from
May 30, 2024

Conversation

lincmba
Copy link
Contributor

@lincmba lincmba commented May 30, 2024

This is to make it consistent with other endpoints

IMPORTANT: Where possible all PRs must be linked to a Github issue

Resolves #61

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for
    bug fixes
  • I have added documentation for any new feature(s) and configuration
    option(s) on the README.md
  • I have run mvn spotless:check to check my code follows the project's
    style guide
  • I have run mvn clean test jacoco:report to confirm the coverage report
    was generated at plugins/target/site/jacoco/index.html
  • I ran mvn clean package right before creating this pull request.

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.73%. Comparing base (d7eeb69) to head (15922cf).
Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #62      +/-   ##
============================================
- Coverage     43.81%   43.73%   -0.09%     
- Complexity      106      107       +1     
============================================
  Files            15       15              
  Lines          1075     1077       +2     
  Branches        120      122       +2     
============================================
  Hits            471      471              
  Misses          545      545              
- Partials         59       61       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

 This is to make it consistent with other endpoints
 fixes #61
@lincmba lincmba force-pushed the consistent_id_for_location_hierarchy branch from 302cccd to 15922cf Compare May 30, 2024 09:23
@pld pld merged commit 812fc4d into main May 30, 2024
1 check passed
@pld pld deleted the consistent_id_for_location_hierarchy branch May 30, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change identifier variable used in LocationHierarchy and PractitionerDetails endpoints
3 participants