Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to HTTP POST for FHIR Search Requests #74

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

lincmba
Copy link
Contributor

@lincmba lincmba commented Jul 23, 2024

fixes #73

IMPORTANT: Where possible all PRs must be linked to a Github issue

Resolves [link to issue]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for
    bug fixes
  • I have added documentation for any new feature(s) and configuration
    option(s) on the README.md
  • I have run mvn spotless:check to check my code follows the project's
    style guide
  • I have run mvn clean test jacoco:report to confirm the coverage report
    was generated at plugins/target/site/jacoco/index.html
  • I ran mvn clean package right before creating this pull request.

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes missing coverage. Please review.

Project coverage is 44.97%. Comparing base (712d495) to head (c11af54).
Report is 5 commits behind head on main.

Files Patch % Lines
...way/plugins/PractitionerDetailsEndpointHelper.java 44.44% 5 Missing ⚠️
...teway/plugins/LocationHierarchyEndpointHelper.java 66.66% 1 Missing ⚠️
.../fhir/gateway/plugins/PermissionAccessChecker.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #74      +/-   ##
============================================
- Coverage     45.01%   44.97%   -0.04%     
  Complexity      130      130              
============================================
  Files            16       16              
  Lines          1213     1225      +12     
  Branches        146      146              
============================================
+ Hits            546      551       +5     
- Misses          600      607       +7     
  Partials         67       67              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndegwamartin
Copy link
Collaborator

Looks good to me, please add the version bump so that we tag for a release

@lincmba lincmba merged commit 8acb65e into main Jul 23, 2024
1 check passed
@lincmba lincmba deleted the use_post_for_fhir_search_requests branch July 23, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to HTTP POST for FHIR Search Requests
4 participants