Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround Fetch Binary breaks with latest JPA HAPI FHIR Server #84

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ndegwamartin
Copy link
Collaborator

IMPORTANT: Where possible all PRs must be linked to a Github issue

Resolves #83

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for
    bug fixes
  • I have added documentation for any new feature(s) and configuration
    option(s) on the README.md
  • I have run mvn spotless:check to check my code follows the project's
    style guide
  • I have run mvn clean test jacoco:report to confirm the coverage report
    was generated at plugins/target/site/jacoco/index.html
  • I ran mvn clean package right before creating this pull request.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 43.27%. Comparing base (712d495) to head (d49fa7b).
Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
...egister/fhir/gateway/plugins/RestTemplateUtil.java 0.00% 9 Missing ⚠️
.../org/smartregister/fhir/gateway/plugins/Utils.java 0.00% 8 Missing ⚠️
.../fhir/gateway/plugins/PermissionAccessChecker.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #84      +/-   ##
============================================
- Coverage     45.01%   43.27%   -1.75%     
- Complexity      130      135       +5     
============================================
  Files            16       17       +1     
  Lines          1213     1345     +132     
  Branches        146      158      +12     
============================================
+ Hits            546      582      +36     
- Misses          600      697      +97     
+ Partials         67       66       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch Binary breaks with latest JPA HAPI FHIR Server
2 participants