Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocationHierarchy Inventory Filter #85

Merged
merged 3 commits into from
Sep 13, 2024
Merged

LocationHierarchy Inventory Filter #85

merged 3 commits into from
Sep 13, 2024

Conversation

lincmba
Copy link
Contributor

@lincmba lincmba commented Sep 13, 2024

fixes #81

IMPORTANT: Where possible all PRs must be linked to a Github issue

Resolves [link to issue]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for
    bug fixes
  • I have added documentation for any new feature(s) and configuration
    option(s) on the README.md
  • I have run mvn spotless:check to check my code follows the project's
    style guide
  • I have run mvn clean test jacoco:report to confirm the coverage report
    was generated at plugins/target/site/jacoco/index.html
  • I ran mvn clean package right before creating this pull request.

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 65.62500% with 11 lines in your changes missing coverage. Please review.

Project coverage is 44.25%. Comparing base (712d495) to head (e5c3ada).
Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
...teway/plugins/LocationHierarchyEndpointHelper.java 70.00% 7 Missing and 2 partials ⚠️
...way/plugins/PractitionerDetailsEndpointHelper.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #85      +/-   ##
============================================
- Coverage     45.01%   44.25%   -0.76%     
- Complexity      130      138       +8     
============================================
  Files            16       16              
  Lines          1213     1358     +145     
  Branches        146      160      +14     
============================================
+ Hits            546      601      +55     
- Misses          600      689      +89     
- Partials         67       68       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dubdabasoduba
dubdabasoduba previously approved these changes Sep 13, 2024
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@lincmba lincmba merged commit 0d76090 into main Sep 13, 2024
1 check passed
@lincmba lincmba deleted the inventory_filter branch September 13, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only download service points with inventory
3 participants