Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain current config files on failure #214

Merged
merged 37 commits into from
Jul 16, 2024

Conversation

hilpitome
Copy link
Contributor

@hilpitome hilpitome commented Jul 10, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #[issue number] or Closes #[issue number]

Engineer Checklist

  • I have run ./gradlew spotlessApply to check my code follows the project's style guide
  • I have built and run the efsity jar to verify my change fixes the issue and/or does not break the application

@pld
Copy link
Member

pld commented Jul 11, 2024

looks good! Can you add tests for this?

@hilpitome hilpitome requested a review from pld July 16, 2024 15:58
@pld pld enabled auto-merge (squash) July 16, 2024 19:01
@pld pld merged commit 8d9db17 into main Jul 16, 2024
4 checks passed
@pld pld deleted the maintain-current-config-files-on-failure branch July 16, 2024 19:02
@hilpitome hilpitome restored the maintain-current-config-files-on-failure branch July 23, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants