Skip to content

Commit

Permalink
Update express version in DockerFilie (#1464)
Browse files Browse the repository at this point in the history
* Update express version in DockerFilie

* Update base image for buliding express server

* Enable corepack in node js images
  • Loading branch information
peterMuriuki authored Aug 30, 2024
1 parent e5f0edf commit eae0f71
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
FROM alpine/git AS sources

# TODO - update the tag here
RUN git clone --branch=v2.1.1-rc1 https://github.com/onaio/express-server.git /usr/src/express-server
RUN git clone --branch=v2.1.1-rc3 https://github.com/onaio/express-server.git /usr/src/express-server

FROM node:16.18-alpine as build

Expand All @@ -23,7 +23,9 @@ USER node
RUN yarn lerna run build


FROM node:16.18-alpine as nodejsbuild
FROM node:20-alpine as nodejsbuild

RUN corepack enable

COPY --from=sources /usr/src/express-server /usr/src/express-server

Expand All @@ -37,6 +39,8 @@ RUN rm -rf ./node_modules/typescript

FROM nikolaik/python-nodejs:python3.12-nodejs22-alpine as final

RUN corepack enable

# Use tini for NodeJS application https://github.com/nodejs/docker-node/blob/master/docs/BestPractices.md#handling-kernel-signals
RUN apk add --no-cache tini curl libmagic

Expand Down

0 comments on commit eae0f71

Please sign in to comment.