Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort and filters #1491

Merged
merged 11 commits into from
Oct 31, 2024
Merged

Sort and filters #1491

merged 11 commits into from
Oct 31, 2024

Conversation

peterMuriuki
Copy link
Collaborator

Changes included with this PR

  • Update commodity list to use client side sorting and filtering.
  • Added status and asset filters to commodity data grid view
  • Added status filter to user management view

Checklist

  • tests are included and passing
  • Internationalization:
    • Ensure all strings are internationalized.
  • Role-Based Access:
    • Verify that all user actions have appropriate role-based access permissions set.

@peterMuriuki peterMuriuki mentioned this pull request Oct 29, 2024
Closed
1 task
ciremusyoka
ciremusyoka approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@ciremusyoka ciremusyoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterMuriuki peterMuriuki merged commit c4fcd61 into main Oct 31, 2024
0 of 2 checks passed
@peterMuriuki peterMuriuki deleted the sort-and-filters branch October 31, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciremusyoka ciremusyoka ciremusyoka approved these changes

@kahummer kahummer Awaiting requested review from kahummer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[EUSM] Add sorting across all lists [EUSM] Hide the inactive locations, users and products
2 participants
@peterMuriuki @ciremusyoka