Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker build push ci #617

Merged
merged 3 commits into from
Apr 29, 2021
Merged

Add docker build push ci #617

merged 3 commits into from
Apr 29, 2021

Conversation

bennsimon
Copy link
Contributor

@bennsimon bennsimon commented Apr 27, 2021

Things noticed during docker image build.

@bennsimon bennsimon requested a review from KipSigei April 27, 2021 10:20
@bennsimon bennsimon force-pushed the add-docker-build-push-ci branch from 706c0e2 to 64e7763 Compare April 27, 2021 10:47
bennsimon and others added 3 commits April 28, 2021 18:09
@bennsimon bennsimon force-pushed the add-docker-build-push-ci branch from f7df979 to a61814c Compare April 28, 2021 15:09
@peterMuriuki
Copy link
Collaborator

@bennsimon is there an issue for the things that need to be revisited?

@bennsimon
Copy link
Contributor Author

@bennsimon is there an issue for the things that need to be revisited?

@p-netm Added it here #627

@peterMuriuki peterMuriuki merged commit 56e8772 into master Apr 29, 2021
@peterMuriuki peterMuriuki deleted the add-docker-build-push-ci branch April 29, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants