Add Location unit #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests are failing. we need to fix #69 first |
Closed
4 tasks
ashfahan
requested review from
peterMuriuki,
KipSigei,
moshthepitt and
kelvin-muchiri
moshthepitt
reviewed
Oct 23, 2020
moshthepitt
previously requested changes
Oct 23, 2020
client/src/containers/pages/Home/tests/__snapshots__/Home.test.tsx.snap
Outdated
Show resolved
Hide resolved
client/src/containers/pages/locations/LocationDetail/tests/__snapshots__/index.test.tsx.snap
Outdated
Show resolved
Hide resolved
client/src/containers/pages/locations/LocationUnit/tests/__snapshots__/index.test.tsx.snap
Outdated
Show resolved
Hide resolved
moshthepitt
reviewed
Oct 23, 2020
after #55 gets merged the View will be exactly like https://marvelapp.com/prototype/f3igd3h/screen/73173137 & https://marvelapp.com/prototype/f3igd3h/screen/73173136 |
KipSigei
force-pushed
the
#48-Page-locationUnit
branch
from
ad0bd7a to
02bec50
Compare
dubdabasoduba
previously approved these changes
Dec 16, 2020
ashfahan
dismissed stale reviews from dubdabasoduba and moshthepitt
via
8ff1bcc
kahummer
previously approved these changes
Dec 16, 2020
kahummer
previously approved these changes
Dec 16, 2020
dubdabasoduba
previously approved these changes
Dec 16, 2020
ashfahan
dismissed stale reviews from dubdabasoduba and kahummer
via
17e8c5b
ashfahan
dismissed
moshthepitt’s stale review
Updates snapshot and conflicts in client
kahummer
approved these changes
Dec 16, 2020
moshthepitt
approved these changes
Dec 16, 2020
dubdabasoduba
approved these changes
Dec 16, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #48