Update dependencies #961
Merged
Update dependencies #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterMuriuki
force-pushed
the
958-update-yarn
branch
2 times, most recently
from
115bc44 to
b392bde
Compare
Moving to yarn v3 proved herculean. the doumnetation already assumes a certain proficiency with yarn itself and its not clear and easily understood, Lack of examples, recipes does not help either. Technically the biggest problem faced was that subpackages were not able to run scripts.
peterMuriuki
force-pushed
the
958-update-yarn
branch
from
d47f94e to
0e6cdff
Compare
This reverts commit 0537a6e.
peterMuriuki
changed the title
Moving to yarn v3 proved herculean. the doumnetation already assumes a certain proficiency with yarn itself and its not clear and easily understood, Lack of examples, recipes does not help either. Technically the biggest problem faced was that subpackages were not able to run scripts.
peterMuriuki
force-pushed
the
958-update-yarn
branch
from
37d21b5 to
e487af0
Compare
| @@ -56,6 +61,5 @@ | |||
| "i18next-parser": "^3.5.0" | |||
| }, | |||
| "author": "OpenSRP Engineering", | |||
| "license": "Apache-2.0", | |||
| "private": false | |||
There was a problem hiding this comment.
why? I think lerna requires this to be false in order to publish
There was a problem hiding this comment.
It was automatically removed by one of the yarn versions I tried installing, left it because I still intend to migrate to the newer yarn versions. No lerna does not require this to be false in order to publish, it however will not publish if it is set to true.
| "dependencies": { | ||
| "@onaio/utils": "^0.0.1", | ||
| "date-fns": "2.11.1", | ||
| "lodash": "^4.17.20", | ||
| "moment": "^2.29.1", |
There was a problem hiding this comment.
this is being used in the package
machariamuguku
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #433
close #958
close #956
close #894
Update package dependencies
Update setup readme