Fix success/Cancel url prop in fhir location form #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machariamuguku
requested changes
Apr 21, 2022
packages/fhir-location-management/src/components/LocationForm/index.tsx
Outdated
Show resolved
Hide resolved
peterMuriuki
force-pushed
the
948-location-redirection
branch
from
c1987de to
07d71a1
Compare
Fixes problem where user edits a location, they are redirected back to the location unit list view, user immediately tries to re-edit the recently edited location, the form values were not those freshly picked from the api
Add alert when refetching tree location hierarchy
peterMuriuki
commented
May 13, 2022
| React.useEffect(() => { | ||
| form.setFieldsValue({ ...initialValues }); | ||
| useDeepCompareEffect(() => { | ||
| form.resetFields(); |
There was a problem hiding this comment.
@p-netm I still feel we should show a loader as the list is re-evaluated
There was a problem hiding this comment.
@machariamuguku this will show a banner when the location hierarchy is being refetched: ade8d65
Codecov Report
@@ Coverage Diff @@
## master #974 +/- ##
==========================================
- Coverage 96.67% 95.78% -0.90%
==========================================
Files 288 322 +34
Lines 8911 9815 +904
Branches 1739 2037 +298
==========================================
+ Hits 8615 9401 +786
- Misses 292 409 +117
- Partials 4 5 +1
Continue to review full report at Codecov.
|
machariamuguku
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix success/Cancel url prop in fhir location form
close #948