Shapefile bugfixes #146
Merged
Shapefile bugfixes #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make it work with dotted file names e.g. a.b.shp instead of just a.shp - Add option to check for number of exact shapefile files - Check for presence of `.dbf` and `.shx` files - General cleanup
ukanga
reviewed
Feb 25, 2019
|
|
||
| result = [] | ||
| for item in geom_object_list: | ||
| if settings.TASKING_SHAPEFILE_IGNORE_INVALID_TYPES: |
There was a problem hiding this comment.
What are the invalid types? MultuPolygons? Why?
There was a problem hiding this comment.
Invalid Types are anything other than Polygons - the ones we know about so far are MultiPolygons and Points.
They are invalid because multipolygon = MultiPolygon(polygons) fails if polygons contains anything other than Polygon objects.
| if ignore_invalid: | ||
| pass | ||
| else: | ||
| results.append(multipolygon_obj) |
There was a problem hiding this comment.
The if-block could be simpler I think.
if not ignore_invalid:
results.append(multipolygon_obj)There was a problem hiding this comment.
thanks, will do this
moshthepitt
force-pushed
the
shapefile-bugfixes
branch
from
272f621
to
eb78799
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #145