Upgrade to django-filter v2 #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisRayM
changed the title
DavisRayM
force-pushed
the
136-upgrade-tasking
branch
from
54156f7
to
934631d
Compare
- Remove Backports Package - Use tempfile lib - Update tests - Update models, serializers and viewsets - Remove tox and travis python2 environments - Remove Future Package - Remove Future Module Dependency - Modify setup.cfg
DavisRayM
force-pushed
the
136-upgrade-tasking
branch
4 times, most recently
from
a8e75ef
to
6a6f738
Compare
DavisRayM
changed the title
DavisRayM
force-pushed
the
136-upgrade-tasking
branch
from
14d24f9
to
8a8e50b
Compare
moshthepitt
suggested changes
Jan 15, 2020
| @@ -1,10 +1,8 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
Could you comment on what necessitated the changes in this module?
There was a problem hiding this comment.
The new django-filter doesn't support passing lists to lookup_expr like we used to do before. Needed to create a separate filter backend TaskOccurrenceFilter to handle the filtering of task occurrences from the tasks endpoint.
| @@ -25,7 +21,7 @@ def test_submission_model_str(self): | |||
| submission = mommy.make( | |||
| 'tasking.Submission', | |||
| task=cattle, | |||
| _fill_optional=['user', 'comment', 'submission_time']) | |||
There was a problem hiding this comment.
What are the effects of changing from comment to comments?
There was a problem hiding this comment.
The comment field doesn't exist for the Submission model.
| expected = 'Cow prices - {}'.format(cow_price.pk) | ||
| self.assertEqual(expected, six.text_type(cow_price)) | ||
| expected = f'Cow prices - {cow_price.pk}' | ||
| self.assertEqual(expected, str(cow_price)) |
There was a problem hiding this comment.
This test was testing the string representation of the object. I can replace this with a call to __str__() though.
- Update Pipfile Lock - Update tests - Update TaskFilterSet to utilize LookUpChoiceFilter
DavisRayM
force-pushed
the
136-upgrade-tasking
branch
from
8a8e50b
to
44f3481
Compare
moshthepitt
approved these changes
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #136
Previous PR #138